New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NULL bytes in get_components() values #804

Merged
merged 2 commits into from Jan 21, 2019

Conversation

Projects
None yet
3 participants
@romuald
Copy link
Contributor

romuald commented Jan 8, 2019

Some old software may generate "bogus" CN with each character preceded
by a NULL.

This is already handled in commonName, but wasn't in get_components()

Handle NULL bytes in get_components() values
Some old software may generate "bogus" CN with each character preceded
by a NULL.

This is already handled in commonName, but wasn't in get_components()
@romuald

This comment has been minimized.

Copy link
Contributor Author

romuald commented Jan 8, 2019

(2 failed tests here, but they are the same as the tests failing on the master branch)

@reaperhulk

This comment has been minimized.

Copy link
Member

reaperhulk commented Jan 8, 2019

You'll need to use b'CN' so that the test can work on both python 2 and 3. Additionally, this can be simplified to: value = _ffi.buffer(_lib.ASN1_STRING_data(fval), _lib.ASN1_STRING_length(fval))[:] rather than unpack call.

@romuald

This comment has been minimized.

Copy link
Contributor Author

romuald commented Jan 9, 2019

@reaperhulk done. I'm not familiar with FFI yet thanks :)

@reaperhulk

This comment has been minimized.

Copy link
Member

reaperhulk commented Jan 9, 2019

Thanks for the quick update. Now the maintainers (that includes me, sigh) need to fix the other tests so we can get this merged!

@reaperhulk reaperhulk added this to the 19.0.0 milestone Jan 21, 2019

@alex

alex approved these changes Jan 21, 2019

@alex alex merged commit 4183beb into pyca:master Jan 21, 2019

3 checks passed

codecov/patch 100% of diff hit (target 97.07%)
Details
codecov/project 97.33% (+0.26%) compared to 37e6022
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

peterbe added a commit to peterbe/django-peterbecom that referenced this pull request Jan 22, 2019

Update pyopenssl to 19.0.0 (#517)
This PR updates [pyOpenSSL](https://pypi.org/project/pyOpenSSL) from **18.0.0** to **19.0.0**.



<details>
  <summary>Changelog</summary>
  
  
   ### 19.0.0
   ```
   -------------------


Backward-incompatible changes:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

- ``X509Store.add_cert`` no longer raises an error if you add a duplicate cert.
  `787 &lt;https://github.com/pyca/pyopenssl/pull/787&gt;`_


Deprecations:
^^^^^^^^^^^^^

*none*


Changes:
^^^^^^^^

- pyOpenSSL now works with OpenSSL 1.1.1.
  `805 &lt;https://github.com/pyca/pyopenssl/pull/805&gt;`_
- pyOpenSSL now handles NUL bytes in ``X509Name.get_components()``
  `804 &lt;https://github.com/pyca/pyopenssl/pull/804&gt;`_



----
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/pyopenssl
  - Changelog: https://pyup.io/changelogs/pyopenssl/
  - Homepage: https://pyopenssl.org/
  - Docs: https://pythonhosted.org/pyOpenSSL/
</details>

peterbe added a commit to mozilla-services/tecken that referenced this pull request Jan 22, 2019

Update pyopenssl to 19.0.0 (#1502)
This PR updates [pyOpenSSL](https://pypi.org/project/pyOpenSSL) from **18.0.0** to **19.0.0**.



<details>
  <summary>Changelog</summary>
  
  
   ### 19.0.0
   ```
   -------------------


Backward-incompatible changes:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

- ``X509Store.add_cert`` no longer raises an error if you add a duplicate cert.
  `787 &lt;https://github.com/pyca/pyopenssl/pull/787&gt;`_


Deprecations:
^^^^^^^^^^^^^

*none*


Changes:
^^^^^^^^

- pyOpenSSL now works with OpenSSL 1.1.1.
  `805 &lt;https://github.com/pyca/pyopenssl/pull/805&gt;`_
- pyOpenSSL now handles NUL bytes in ``X509Name.get_components()``
  `804 &lt;https://github.com/pyca/pyopenssl/pull/804&gt;`_



----
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/pyopenssl
  - Changelog: https://pyup.io/changelogs/pyopenssl/
  - Homepage: https://pyopenssl.org/
  - Docs: https://pythonhosted.org/pyOpenSSL/
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment