Make tests pass after 2019 #828
Conversation
|
Added commits to make tests pass in 2037. |
Without this patch, TestX509StoreContext.test_valid and 5 other tests would fail after 2020-01-01 Fixes pyca#735 This PR was done while working on reproducible builds for openSUSE.
coming from tests/test_crypto.py
|
Why is there always some unrelated travis check failing? How is someone supposed to get anything done in such an environment? |
|
pyOpenSSL is a widely used project and as such it has some downstream tests for prominent packages to make sure changes do not break them. urllib3 is one such package. Unfortunately, its test suite is somewhat flaky, but we have judged the value of keeping it in the test suite to be higher than the cost. Repository owners can trigger retries but PR authors can also push empty commits to cause it to rebuild in the case of flakiness like that. I restarted the job and it passed, so there you go. Of course, your change fails the check-manifest job for legitimate reasons which you should look into. |
The 6840 in Makefile is due to some y2038 bug - should have been 363000
but one test failed then:
with pytest.raises(X509StoreContextError) as exc:
store_ctx.verify_certificate()
> assert exc.value.args[0][2] == 'certificate has expired'
E AssertionError: assert 'format error...tBefore field' == 'certi
as expired'
E - format error in certificate's notBefore field
E + certificate has expired
tests/test_crypto.py:3572: AssertionError
|
Thanks for the hint. The manifest problem was not so obvious (I do not do that much python). Pushed a fix and it looks greener now. |
|
ping |
|
2020 is getting closer and I would still like to see this merged. Or is there anything else that needs improvement? |
|
Well, thanks for this PR/patch! Fixes tests that started failing now that it's 2020 :). |
|
Just want to note that we're not ignoring this intentionally.... we're just very bad and unmotivated with respect to pyOpenSSL. |
|
It's 2020, tests are passing, can we declare this complete? |
Without this patch,
TestX509StoreContext.test_validand 5 other testswould fail after 2020-01-01
Fixes #735
This PR was done while working on reproducible builds for openSUSE.
Without the later commits, tests were failing in 2037 from pem files embedded in
tests/test_crypto.pyas can be seen by pasting them into
openssl x509 -text | grep Not.After