/ pyopenssl Public
Context.set_verify: allow omission of callback #933
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
This PR allows it to call
set_verifywithout specifying an explicit callback:
This simplifies the most common case to
context.set_verify(SSL.VERIFY_PEER). Now that OpenSSL has builtin hostname validation, it's probably a good thing to discourage people from writing custom certificate verification.