/ pyopenssl Public
crypto._PassphraseHelper: pass non-callable passphrase using callback #947
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Before this PR, we would pass a bytes passphrase as a null terminated string.
This causes issue when a randomly generated key's first byte is null because OpenSSL rightly determines the key length is 0.
This PR modifies the passphrase helper to pass the passphrase via the callback and adds tests to prevent regression.