Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more descriptive error messages, if possible #129

Closed
amjokisaari opened this issue Sep 21, 2017 · 0 comments · Fixed by #141
Closed

more descriptive error messages, if possible #129

amjokisaari opened this issue Sep 21, 2017 · 0 comments · Fixed by #141
Assignees

Comments

@amjokisaari
Copy link

amjokisaari commented Sep 21, 2017

When inputting a phase into the phase list that does not exist in the TDB, attempting to use this list in, e.g., binplot() results in the not-terribly-useful error message: KeyError: . It's fairly easy to figure out, but it would be nice if there were a check or a message like "this phase does not exist in the TDB."

If I come across additional places for more helpful messages, I'll update this until it's closed.

Update: Also, there should be an error message for the bug in issue #116, instead of silently calculating the wrong free energy.

@bocklund bocklund self-assigned this Nov 12, 2017
bocklund added a commit to bocklund/pycalphad that referenced this issue Aug 17, 2021
…#130)

Fixes a bug revealed by NumPy `1.19` where assigning arrays with extra dimensions of size 1 were not automatically broadcasted. The solution was to avoid using sympy.Matrix, which introduced additional dimensions that were difficult to reason about. Extended discussion can be found on pycalphadgh-130 and closes pycalphadgh-129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants