FIX: calculate: Phase index offset for associate models #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bocklund
reviewed
Aug 10, 2021
Codecov Report
@@ Coverage Diff @@
## develop #368 +/- ##
===========================================
+ Coverage 89.91% 89.93% +0.01%
===========================================
Files 44 44
Lines 4362 4370 +8
===========================================
+ Hits 3922 3930 +8
Misses 440 440
Continue to review full report at Codecov.
|
bocklund
reviewed
Aug 11, 2021
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
bocklund
approved these changes
Aug 11, 2021
bocklund
pushed a commit
to PhasesResearchLab/ESPEI
that referenced
this pull request
Aug 13, 2021
…rom non-pure element species (#208) Propagate changes from [PR 368](pycalphad/pycalphad#368) to espei.shadow_functions.calculate_ to fix the phase index offset for Database with non-pure element species.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-367.