Skip to content

tdb: ELEMENT with missing '!' line terminator can silently eat the next line #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
richardotis opened this issue Oct 20, 2016 · 0 comments
Closed

tdb: ELEMENT with missing '!' line terminator can silently eat the next line #57

richardotis opened this issue Oct 20, 2016 · 0 comments
Assignees
@richardotis
Labels
bug

Comments

@richardotis
Copy link
Collaborator

Example

$ Note missing '!' in next line
ELEMENT ZR   BCT_A5                    
FUNCTION EMBCCTI    298.15 -39.72; 6000 N !

Current Behavior

The TDB parser will concatenate these lines together like ELEMENT ZR BCT_A5 FUNCTION EMBCCTI 298.15 -39.72; 6000 N. Because the grammar rule for ELEMENTs is so permissive, it will silently ignore everything after the element name.

Expected Behavior

The parser should raise a ParseException.
@richardotis richardotis self-assigned this Oct 20, 2016
bocklund added a commit to bocklund/pycalphad that referenced this issue Aug 17, 2021
@bocklund
FIX: Check datasets support for activity data. Closes pycalphad#56 (p…
0f068b5 
…ycalphad#57)

* MAINT: Make get_pure_elements non-private

* FIX: Check datasets support for activity data. Closes pycalphad#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardotis richardotis

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richardotis