FIX: sympy 1.1 compatibility #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y 1.1 import changes. Fixes gh-105.
|
Can you remind me why we are import checking rather than just Something about python 3.4 support, right? |
|
Why break backcompat when you can keep it with a two line check?
And I think Python 3.4 support will be going away soon when IPOPT starts getting merged.
|
|
That's fine. Still some failing tests here |
Warning testing is independent of the number of warnings raised and depends instead on specific string fragments.
Warning testing is independent of the number of warnings raised and depends instead on specific string fragments.
…y 1.1 import changes. Fixes gh-105.
…into fix_sympy11
…inity' on MSVC compilers
|
Looks like Mac builds are failing on travis, but everything else looks ok. |
|
|
|
Tracking issue: sympy/sympy#12895 |
bocklund
approved these changes
Jul 28, 2017
|
Based on separate discussion, we think this is suitable for merge. We'll work with upstream to get the issue with gmpy2 fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-105.