New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: sympy 1.1 compatibility #108

Merged
merged 6 commits into from Jul 31, 2017

Conversation

Projects
None yet
2 participants
@richardotis
Collaborator

richardotis commented Jul 20, 2017

Fixes gh-105.

@richardotis richardotis requested a review from bocklund Jul 20, 2017

@bocklund

This comment has been minimized.

Collaborator

bocklund commented Jul 20, 2017

Can you remind me why we are import checking rather than just sympy >= 1.1?

Something about python 3.4 support, right?

@richardotis

This comment has been minimized.

Collaborator

richardotis commented Jul 20, 2017

@bocklund

This comment has been minimized.

Collaborator

bocklund commented Jul 23, 2017

That's fine. Still some failing tests here

bocklund and others added some commits Jul 23, 2017

FIX: Improve tests that check warnings.
Warning testing is independent of the number of warnings raised and depends
 instead on specific string fragments.
FIX: Improve tests that check warnings.
Warning testing is independent of the number of warnings raised and depends
 instead on specific string fragments.
@bocklund

This comment has been minimized.

Collaborator

bocklund commented Jul 28, 2017

Looks like Mac builds are failing on travis, but everything else looks ok.

@richardotis

This comment has been minimized.

Collaborator

richardotis commented Jul 28, 2017

TypeError: argument is not an mpz is an indication that gmpy2 is installed. It's purposefully excluded from the Linux-based Docker images but it's slipping into the Mac builds.

@richardotis

This comment has been minimized.

Collaborator

richardotis commented Jul 28, 2017

Tracking issue: sympy/sympy#12895

@bocklund

Looks good. Open issue to pin version to >1.1 on upstream fix of gmpy in SymPy

@richardotis

This comment has been minimized.

Collaborator

richardotis commented Jul 28, 2017

Based on separate discussion, we think this is suitable for merge. We'll work with upstream to get the issue with gmpy2 fixed.

@richardotis richardotis merged commit 57103aa into develop Jul 31, 2017

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 87.006%
Details

@richardotis richardotis deleted the fix_sympy11 branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment