Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Database.write should raise if one of the specified values is not entered. #117

Merged
merged 3 commits into from Aug 9, 2017

Conversation

@bocklund
Copy link
Collaborator

@bocklund bocklund commented Aug 6, 2017

Closes #94.

This handles cases where if_exists is passed a string that is not in ['raise', 'overwrite', 'rename']. In that case, we should raise rather than overwrite.

@bocklund bocklund requested a review from richardotis Aug 6, 2017
Copy link
Collaborator

@richardotis richardotis left a comment

How about a test?

@bocklund bocklund force-pushed the fix-database-write-default branch from 379e39a to 64c42db Aug 7, 2017
@bocklund
Copy link
Collaborator Author

@bocklund bocklund commented Aug 7, 2017

+1 for tests revealing breakages. FileExistsError was introduced in Python 3.3.

bocklund added 3 commits Aug 7, 2017
…t entered

Closes #94.

This handles cases where `if_exists` is passed a string that is not in ['raise', 'overwrite', 'rename']. In that case, we should raise rather than overwrite.
@bocklund bocklund force-pushed the fix-database-write-default branch from 133e8a9 to bef336a Aug 8, 2017
@richardotis
Copy link
Collaborator

@richardotis richardotis commented Aug 9, 2017

Looks good to merge pending tests.

@richardotis richardotis added this to the 0.5.2 milestone Aug 9, 2017
@bocklund bocklund merged commit 3d6c91b into develop Aug 9, 2017
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.4%) to 87.356%
Details
@bocklund bocklund deleted the fix-database-write-default branch Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.