New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Cleanup refdata, fitting, and core.eqresult #135

Merged
merged 3 commits into from Nov 3, 2017

Conversation

Projects
None yet
2 participants
@bocklund
Collaborator

bocklund commented Oct 9, 2017

These modules appear to be dead code and unused and are removed.
Potentially useful is the pycalphad.refdata, which has been moved to ESPEI because it fits more into the scope of ESPEI than pycalphad.

refdata will be released in ESPEI with ESPEI version 0.3.1

@bocklund

This comment has been minimized.

Collaborator

bocklund commented Oct 9, 2017

# DO NOT MERGE UNTIL ESPEI 0.3.1 IS RELEASED WITH REFDATA

I've replaced the code in the refdata module with an import error saying that it has been moved to ESPEI. @richardotis do you think this is necessary? Should we include a date that the pycalphad.refdata module will be removed from pycalphad, e.g. pycalphad 0.7?

@bocklund

This comment has been minimized.

Collaborator

bocklund commented Nov 1, 2017

This is ready for a review

@bocklund bocklund requested a review from richardotis Nov 1, 2017

@bocklund bocklund merged commit 3d7a550 into develop Nov 3, 2017

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 87.29%
Details

@bocklund bocklund deleted the refdata-fix branch Nov 3, 2017

richardotis added a commit that referenced this pull request Nov 26, 2017

MAINT: Cleanup refdata, fitting, and core.eqresult (#135)
* Remove refdata, fitting, and core.eqresult code that is dead.
* Raise import error in refdata pointing users to ESPEI 0.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment