New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Plot tielines option #136

Merged
merged 4 commits into from Oct 31, 2017

Conversation

Projects
None yet
2 participants
@bocklund
Collaborator

bocklund commented Oct 12, 2017

Add a tieline bool option to turn off tieline plotting in eqplot

The keyword argument is propagated from binplot/ternplot kwargs and there
is not an explicit keyword argument. Should there be?

This also changes the plot colorlist by removing the awful yellow and changing the order. By changing the order we don't guarantee that to like colors are not next to each other on the phase diagram, but when the number of phases is small we can ensure that only unique colors show up.

bocklund added some commits Oct 12, 2017

ENH: Add a tieline bool option to turn off tieline plotting in eqplot
The keyword argument is propagated from binplot/ternplot kwargs and there
is not an explicit keyword argument. Should there be?

Closes #125
ENH: Change plot colorlist by removing the awful yellow and changing …
…the order

By changing the order we don't guarantee that to like colors are not next
to each other, but when the number of phases is small we can ensure that
only unique colors show up.

@bocklund bocklund requested a review from richardotis Oct 12, 2017

@richardotis

This comment has been minimized.

Collaborator

richardotis commented Oct 18, 2017

Tests on Travis are failing but it looks like it's due to gmpy2 sneaking in again as a dependency and triggering sympy/sympy#12895 . Since the tests on the other platforms pass I'm going to ignore that issue for the purposes of the review.

@richardotis

This comment has been minimized.

Collaborator

richardotis commented Oct 18, 2017

An explicit keyword argument in binplot and ternplot is unnecessary.

@richardotis

This comment has been minimized.

Collaborator

richardotis commented Oct 18, 2017

Since this is difficult to test for in CI, could you add an example here in this issue showing the tielines option turned on and off for a binary and ternary phase diagram?

@bocklund bocklund merged commit 2baf14c into develop Oct 31, 2017

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.3%) to 87.597%
Details

@bocklund bocklund deleted the plot-tielines branch Oct 31, 2017

richardotis added a commit that referenced this pull request Nov 26, 2017

ENH: Add plot tielines option (#136)
* Add a tieline bool option to turn off tieline plotting in eqplot
* Changes plot colorlist by removing the awful yellow and changing the order
* Update BinaryExamples with new usage of tielines=False

Closes #125

By changing the order we don't guarantee that to like colors are not next
to each other, but when the number of phases is small we can ensure that
only unique colors show up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment