New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SymPy 1.2 compatibility #180

Merged
merged 3 commits into from Aug 17, 2018

Conversation

Projects
None yet
2 participants
@richardotis
Collaborator

richardotis commented Jul 17, 2018

Provides compatibility fixes for codegen changes, as well as a workaround for sympy/sympy#14933

@bocklund

This comment has been minimized.

Collaborator

bocklund commented Jul 17, 2018

Looks like conda is trying to update to py37 for some reason, causing failures for py27 builds.

@bocklund

This comment has been minimized.

Collaborator

bocklund commented Jul 17, 2018

@richardotis can you add some comments to the Piecewise patch that make it clearer what is patched and why?

@bocklund

This comment has been minimized.

Collaborator

bocklund commented Aug 17, 2018

Is anything holding up merging this?

args = []
for e, c in _args:
if not c.is_Atom and not isinstance(c, Relational):
free = c.expr_free_symbols

This comment has been minimized.

@richardotis

richardotis Aug 17, 2018

Collaborator

This is the only line that was changed compared to the sympy 1.2 base; originally it was c.free_symbols. Details in sympy/sympy#14933

@richardotis

This comment has been minimized.

Collaborator

richardotis commented Aug 17, 2018

There are no blockers to merging this. On a related note, we should probably think about running the test suite against sympy master every once in a while, to avoid getting blindsided by another release.

@bocklund

This comment has been minimized.

Collaborator

bocklund commented Aug 17, 2018

I added a comment. If the tests pass on CI, I'll go ahead and merge and rebase the other PRs

@bocklund bocklund merged commit e34a832 into develop Aug 17, 2018

1 of 5 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
coverage/coveralls Coverage decreased (-0.5%) to 87.306%
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bocklund bocklund added this to the 0.7.1 milestone Aug 18, 2018

@richardotis richardotis deleted the fix_sympy12 branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment