Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SymPy 1.2 compatibility #180

Merged
merged 3 commits into from Aug 17, 2018
Merged

SymPy 1.2 compatibility #180

merged 3 commits into from Aug 17, 2018

Conversation

@richardotis
Copy link
Collaborator

@richardotis richardotis commented Jul 17, 2018

Provides compatibility fixes for codegen changes, as well as a workaround for sympy/sympy#14933

@bocklund
Copy link
Collaborator

@bocklund bocklund commented Jul 17, 2018

Looks like conda is trying to update to py37 for some reason, causing failures for py27 builds.

Loading

@bocklund
Copy link
Collaborator

@bocklund bocklund commented Jul 17, 2018

@richardotis can you add some comments to the Piecewise patch that make it clearer what is patched and why?

Loading

@bocklund
Copy link
Collaborator

@bocklund bocklund commented Aug 17, 2018

Is anything holding up merging this?

Loading

args = []
for e, c in _args:
if not c.is_Atom and not isinstance(c, Relational):
free = c.expr_free_symbols
Copy link
Collaborator Author

@richardotis richardotis Aug 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only line that was changed compared to the sympy 1.2 base; originally it was c.free_symbols. Details in sympy/sympy#14933

Loading

@richardotis
Copy link
Collaborator Author

@richardotis richardotis commented Aug 17, 2018

There are no blockers to merging this. On a related note, we should probably think about running the test suite against sympy master every once in a while, to avoid getting blindsided by another release.

Loading

@bocklund
Copy link
Collaborator

@bocklund bocklund commented Aug 17, 2018

I added a comment. If the tests pass on CI, I'll go ahead and merge and rebase the other PRs

Loading

@bocklund bocklund merged commit e34a832 into develop Aug 17, 2018
1 of 5 checks passed
Loading
@bocklund bocklund added this to the 0.7.1 milestone Aug 18, 2018
@richardotis richardotis deleted the fix_sympy12 branch Nov 14, 2018
bocklund added a commit to bocklund/pycalphad that referenced this issue Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants