SymPy 1.2 compatibility #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like conda is trying to update to py37 for some reason, causing failures for py27 builds. |
|
@richardotis can you add some comments to the Piecewise patch that make it clearer what is patched and why? |
|
Is anything holding up merging this? |
richardotis
commented
Aug 17, 2018
| args = [] | ||
| for e, c in _args: | ||
| if not c.is_Atom and not isinstance(c, Relational): | ||
| free = c.expr_free_symbols |
There was a problem hiding this comment.
This is the only line that was changed compared to the sympy 1.2 base; originally it was c.free_symbols. Details in sympy/sympy#14933
|
There are no blockers to merging this. On a related note, we should probably think about running the test suite against sympy master every once in a while, to avoid getting blindsided by another release. |
|
I added a comment. If the tests pass on CI, I'll go ahead and merge and rebase the other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides compatibility fixes for codegen changes, as well as a workaround for sympy/sympy#14933