Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: PhaseRecord: Pickled memoryviews are wrapped in calls to np.array() #196

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

richardotis
Copy link
Collaborator

Fixes gh-178.

@richardotis richardotis added this to the 0.7.1 milestone Nov 13, 2018
@richardotis richardotis merged commit 5535526 into develop Nov 14, 2018
@richardotis richardotis deleted the fix_issue178 branch November 14, 2018 23:54
bocklund added a commit to bocklund/pycalphad that referenced this pull request Aug 17, 2021
- Migrate to pycalphad's new minimizer
- Drop the constrained minimization hack that used SymPy to solve the composition constraints in favor of a naïve approach implemented by `shadow_functions.constrained_equilibrium`
- Fix a (longstanding) bug in the tests introduced by pycalphad#97  where parameters passed to `EmceeOptimizer.predict` would not be coerced to floats and would update the phase record parameters with garbage data.
- Lower the point density in line with what pycalphad does now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant