Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
WIP: Chemical potential conditions support #200
Thank you for the review. The quality of the code has been significantly improved.
In addition to another round of review in light of these revisions, I'd also like your concurrence explicitly on the proposed temporary
While making changes to the solver to improve convergence, I found that the results of this test became unreliable and platform-dependent, requiring minute changes in the calculation temperature to resolve. I now believe that this test working at all was a bug, and for the given set of conditions
I think we have discussed this offline in the past and that freeing up another condition (T in this case) is the correct approach.