Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Improve Model instantiation #217

Merged
merged 3 commits into from May 22, 2019
Merged

FIX: Improve Model instantiation #217

merged 3 commits into from May 22, 2019

Conversation

@bocklund
Copy link
Collaborator

@bocklund bocklund commented May 22, 2019

Two changes here:

  1. instantiate_models now returns a dict instead of a default dict to be more explicit. Only phases passed to instantiate_models are included.
  2. Fixed a subtle bug in calculate where over-specified models could have led to inconsistent maximum internal degree of freedom between calculate and starting_point because calculate based the internal dof size on all the model instances, while starting_point used the phase records (active phases only).
@bocklund bocklund requested a review from richardotis May 22, 2019
pycalphad/tests/test_utils.py Outdated Show resolved Hide resolved
@bocklund bocklund merged commit 5959be6 into develop May 22, 2019
1 of 5 checks passed
@bocklund bocklund deleted the FIX-model-instantiation branch Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants