-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Use symengine #220
Merged
Merged
ENH: Use symengine #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to resolve a SymEngine compatibility issue
…wrap-based codegen
…. Also disable py27 on Windows
bocklund
approved these changes
May 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few additional notes:
- Closes ENH: Use symengine #220 Develop branch breaks eqplot #218 (and properly fixes the already closed wontfix Improve JIT compilation time with symengine #155)
- This breaks
'processes', 'multiprocessing'
as options to scheduler. With equilibrium: dask scheduler default incorrectly set to synchronous #101, these actually were not useful anyways. - This should close Lower convex hull is missing phases #219. Is it possible to take any test code and write a test for lower_convex_hull that ensures we don't see any regressions? Non blocking if a test is not straightforward.
- The test suite is now significantly faster (almost 4x faster on CI, installing pycalphad is more expensive than running the test suite).
- SymPy models are converted to symengine objects just in time before differentiation and building callable functions. This takes about 15% of the time in the test suite for me and we should work towards using symengine primitives throughout pycalphad in the future (which will speed up other areas as well). The blocker for this is pickling symengine objects. Track
- Introduces a patch for avoiding rewriting ITEs in nested Piecewise functions because symengine does not support ITEs
@richardotis can you add a comment to this PR (not in the code) on the changes in hyperplane/lower convex hull. Why are we not penalizing fake points in hyperplane and why the change from global_grid
to grid
in lower convex hull?
Done. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
global_grid
which more correctly go togrid
, to reduce array duplication