Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFIX: SymPy namespace clash with TDBs, and other deprecation fixes #234
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
richardotis commentedAug 2, 2019
Fixes gh-233 and fixes gh-231.
This also addresses the deprecation of
inspect.getargspec
in Python 3, as well as a reorganization of thecollections
standard library module set to go into effect in Python 3.8.For future error reporting, the TDB parser will include some details about the line in the TDB file which caused any exception, regardless of whether it is a syntax mistake in the TDB file (
ParseException
) or a bug further up the stack.