Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: SymPy 1.5 compatibility #251

Merged
merged 2 commits into from Dec 26, 2019
Merged

MAINT: SymPy 1.5 compatibility #251

merged 2 commits into from Dec 26, 2019

Conversation

@bocklund
Copy link
Collaborator

bocklund commented Dec 3, 2019

SymPy 1.5 release candidate 1 is out now. There is one breakage: EmptySet is now a singleton instead of a class (see release notes ).

Here is the simplest change. We also need to bump the requirements to pin sympy>=1.5.

There are a couple other options for changes:

  1. Current change, use the singleton comparison instead of the class
  2. Use the .is_EmptySet property, which is now deprecated in favor of the .is_empty property. Allows us to stay backwards compatible until the deprecated code is removed (sympy/sympy#17523)
  3. Use the .is_empty property, which would still require bumping the version to sympy>=1.5

Staying with comparing to the singleton makes sense to me. I'm opening this PR for discussion. We cannot merge this until SymPy 1.5 is released.

@bocklund bocklund force-pushed the sympy-1.5-compat branch from d1882ba to e176b91 Dec 19, 2019
@bocklund

This comment has been minimized.

Copy link
Collaborator Author

bocklund commented Dec 19, 2019

SymPy 1.5 is released and tests are passing here (except for Python 3.8, see #257)

This is ready for comments @richardotis

@bocklund bocklund requested a review from richardotis Dec 19, 2019
@bocklund bocklund marked this pull request as ready for review Dec 19, 2019
@bocklund bocklund force-pushed the sympy-1.5-compat branch from e176b91 to fc7be25 Dec 26, 2019
@bocklund

This comment has been minimized.

Copy link
Collaborator Author

bocklund commented Dec 26, 2019

Rebased on develop after merging #257 - will merge after tests pass

@bocklund bocklund merged commit 3285447 into develop Dec 26, 2019
4 of 5 checks passed
4 of 5 checks passed
coverage/coveralls Coverage decreased (-0.07%) to 86.086%
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bocklund bocklund deleted the sympy-1.5-compat branch Dec 26, 2019
@bocklund bocklund added this to the 0.8.2 milestone Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.