FIX: _eqcalculate: Rename models
-> model
for backwards compatibility
#272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In reviewing #270, I overlooked the fact that
calculate
takes the argumentmodel
, which a caller could pass as a keyword argument to_eqcalculate
. #270 changed_eqcalculate
to explicitly take amodels
argument and pass it tocalculate
.This preserves the behavior from #270 and stays backwards compatible if anyone was using
model
as a keyword argument that got passed through tocalculate
.