Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: _eqcalculate: Rename models -> model for backwards compatibility #272

merged 1 commit into from Apr 11, 2020


Copy link

In reviewing #270, I overlooked the fact that calculate takes the argument model, which a caller could pass as a keyword argument to _eqcalculate. #270 changed _eqcalculate to explicitly take a models argument and pass it to calculate.

This preserves the behavior from #270 and stays backwards compatible if anyone was using model as a keyword argument that got passed through to calculate.

@bocklund bocklund merged commit 7e167bf into develop Apr 11, 2020
@bocklund bocklund deleted the fix-backwards-compatible-eqcalculate branch Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants