FIX: Two sublattice ionic liquid fixes and tests #273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR fixes two bugs in the implementation of ionic liquid two sublattice model
Model
to be valid parameters and to correct their sublattice index in the Redlich-Kister sum to produce the correctv.SiteFraction
objects.Model
class corresponding to any phase with theionic_liquid_2SL
model hint applied.This PR includes
[1] Sundman, "Modification of the two-sublattice model for liquids", Calphad 15(2) (1991) 109-119 https://doi.org/d3jppb