Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Bump cyipopt to support new package name and v1.0 API; bump SymPy and SymEngine #289

Merged
merged 10 commits into from
Apr 26, 2021

Conversation

bocklund
Copy link
Collaborator

@bocklund bocklund commented Dec 4, 2020

Checklist

  • The documentation examples have been regenerated if the Jupyter notebooks in the examples/ have changed. To regenerate the documentation examples, run jupyter nbconvert --to rst --output-dir=docs/examples examples/*.ipynb from the top level directory)
  • If any dependencies have changed, the changes are reflected in the
    • setup.py
    • environment-dev.yml

This PR:

  • Bumps versions on cyipopt, symengine, python-symengine and sympy
  • Updates API of cyipopt for >1.0
  • Adds pip check to the Test GitHub Action to try to protect against inconsistent dependencies between setup.py and those installed by environment-dev.yml

@bocklund
Copy link
Collaborator Author

bocklund commented Dec 4, 2020

We'll wait to merge this until cyipopt 1.0 is released to pypi and conda-forge. This should allow us to drop the pycalphad channel as cyipopt 0.3 and later should support Windows builds on conda-forge.

  • drop the pycalphad channel from environment-dev.yml
  • drop the pycalphad channel from the installation instruction docs

@bocklund bocklund added the waiting-for-upstream Waiting for upstream packages to be updated label Mar 9, 2021
@bocklund
Copy link
Collaborator Author

bocklund commented Apr 7, 2021

cyipopt 1.0 has been released! The PyPI name is still ipopt until pypi/support#1008 is addressed. Since this does not seem to be happening soon, we should press forward with this PR and make a new issue to switch to the name pending pypi/support#1008.

pycalphad/core/solver.py Outdated Show resolved Hide resolved
pycalphad/core/solver.py Outdated Show resolved Hide resolved
@bocklund bocklund added this to the 0.8.5 milestone Apr 26, 2021
@bocklund bocklund removed the waiting-for-upstream Waiting for upstream packages to be updated label Apr 26, 2021
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #289 (b86d795) into develop (4d02ecb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #289   +/-   ##
========================================
  Coverage    87.14%   87.14%           
========================================
  Files           46       46           
  Lines         4505     4505           
========================================
  Hits          3926     3926           
  Misses         579      579           
Impacted Files Coverage Δ
pycalphad/core/solver.py 88.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d02ecb...b86d795. Read the comment docs.

@bocklund bocklund marked this pull request as ready for review April 26, 2021 03:42
@bocklund bocklund changed the title MAINT: Bump cyipopt to support new package name and v1.0 API MAINT: Bump cyipopt to support new package name and v1.0 API; bump SymPy and SymEngine Apr 26, 2021
@bocklund bocklund merged commit 31776fb into develop Apr 26, 2021
@bocklund bocklund deleted the cyipopt_v1 branch April 26, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants