Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Drop pycalphad conda channel #297

Merged
merged 1 commit into from Jan 7, 2021
Merged

Conversation

bocklund
Copy link
Collaborator

@bocklund bocklund commented Jan 6, 2021

Checklist

  • If any dependencies have changed, the changes are reflected in the
    • setup.py
    • environment-dev.yml

cyipopt is now building on conda-forge for Windows (thanks @moorepants!) so users installing pycalphad via Anaconda do not require the pycalphad channel anymore.

This PR

  • bumps pycalphad's dependency on cyipopt to v0.3 or later (the version required for Windows support)
  • removes the pycalphad channel from the installation instructions.

Since this PR updates the installation instructions, we should not merge it until conda-forge/pycalphad-feedstock#33 is merged and the package has propagated to the conda-forge channel.

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #297 (ed165ce) into develop (d217b4b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #297   +/-   ##
========================================
  Coverage    86.77%   86.77%           
========================================
  Files           46       46           
  Lines         4461     4461           
========================================
  Hits          3871     3871           
  Misses         590      590           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d217b4b...ed165ce. Read the comment docs.

@bocklund
Copy link
Collaborator Author

bocklund commented Jan 7, 2021

The conda-forge pycalphad package has been built and is now available (conda-forge/pycalphad-feedstock#33). I tested that it installs and works locally. This is ready for review.

@bocklund bocklund merged commit dfe945e into develop Jan 7, 2021
@bocklund bocklund deleted the cyipopt-channel-bump branch March 15, 2021 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants