FIX: Improve strictness when parsing TDB FUNCTION and PARAMETER lines #308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
examples/
have changed. To regenerate the documentation examples, runjupyter nbconvert --to rst --output-dir=docs/examples examples/*.ipynb
from the top level directory)setup.py
environment-dev.yml
This PR makes the TDB parser more strict by requiring that PARAMETER and FUNCTION lines are terminated by an optional-suppressed reference key and a line end. This fixes behavior where the parser would silently consume all TDB content until the next line terminator (
!
) for these two commands once thefunc_expr
grammar was successfully parsed.FUNCTION
andPARAMETER
pyparsing grammars are updated to include through the line ending, if the parsed function expression and reference key is not following by a line ending, aParseException
is now raised.REF: 0
, which I changed toREF0
(I also verified that Thermo-Calc 2020b says thatREF: 0
is an invalid reference format in GES6)