Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Bump SymEngine pin to 0.7.0 #316

Merged
merged 3 commits into from Mar 23, 2021

Conversation

bocklund
Copy link
Collaborator

@bocklund bocklund commented Mar 15, 2021

Checklist

  • The documentation examples have been regenerated if the Jupyter notebooks in the examples/ have changed. To regenerate the documentation examples, run jupyter nbconvert --to rst --output-dir=docs/examples examples/*.ipynb from the top level directory)
  • If any dependencies have changed, the changes are reflected in the
    • setup.py
    • environment-dev.yml

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #316 (2815748) into develop (5038950) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #316   +/-   ##
========================================
  Coverage    86.78%   86.78%           
========================================
  Files           46       46           
  Lines         4464     4464           
========================================
  Hits          3874     3874           
  Misses         590      590           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5038950...2815748. Read the comment docs.

@bocklund bocklund changed the title MAINT: Bump SymEngine pin to 0.7 MAINT: Bump SymEngine pin to 0.7.0 Mar 15, 2021
Copy link
Collaborator

@richardotis richardotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be bumped for the post-releases?

@bocklund
Copy link
Collaborator Author

Does this need to be bumped for the post-releases?

It doesn't look like the post builds are being released on conda-forge. https://github.com/conda-forge/python-symengine-feedstock/pull/33/files

At least with conda, the single equals sign spec should match all post builds if I'm understanding correctly the example:

The fuzzy constraint numpy=1.11 matches 1.11, 1.11.0, 1.11.1, 1.11.2, 1.11.18, and so on.

For PyPI, assuming PEP-440 is followed, we would need ==0.7.0.* to match the post builds source

@bocklund bocklund merged commit 5a32b8e into pycalphad:develop Mar 23, 2021
@bocklund bocklund deleted the symengine-0.7-bump branch March 23, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants