New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Use PyPA/build to set up source distribution in deploy #330
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #330 +/- ##
========================================
Coverage 87.34% 87.34%
========================================
Files 46 46
Lines 4521 4521
========================================
Hits 3949 3949
Misses 572 572 Continue to review full report at Codecov.
|
Thanks for working this. Does this ensure the tests are run and pass before a tagged commit is built and uploaded? |
This particular workflow does not do that. I don't really see it as blocking because:
|
I agree that it's not a regression to do it this way and that it's fine to move forward. I would eventually like to test the exact artifacts we're uploading to PyPI, particularly once we start building platform wheels. |
3f6447f
to
2d0e800
Compare
twine check
as verified here.pyproject.toml
to explicitly use the legacy setuptools backend, which is required since we vendor a local versioneer and cannot do full PEP 517 build isolation.long_description_content_type
to oursetup.py
to passtwine check