Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use PyPA/build to set up source distribution in deploy #330

merged 9 commits into from May 22, 2021


Copy link

  • Use PyPA/build to build distributions as recommended by setuptools. The source distribution builds and passes twine check as verified here.
  • Update pyproject.toml to explicitly use the legacy setuptools backend, which is required since we vendor a local versioneer and cannot do full PEP 517 build isolation.
  • Add long_description_content_type to our to pass twine check

Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #330 (d9112b7) into develop (db5086c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #330   +/-   ##
  Coverage    87.34%   87.34%           
  Files           46       46           
  Lines         4521     4521           
  Hits          3949     3949           
  Misses         572      572           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db5086c...d9112b7. Read the comment docs.

@bocklund bocklund requested a review from richardotis May 21, 2021 19:01
Copy link

Thanks for working this. Does this ensure the tests are run and pass before a tagged commit is built and uploaded?

Copy link
Collaborator Author

bocklund commented May 21, 2021

This particular workflow does not do that. I don't really see it as blocking because:

  1. The current releasing workflow where developers upload source distributions manually doesn't necessarily ensure that the tests pass in CI
  2. You can mitigate and ensure the tests pass on CI "manually" by pushing the commit you're planning to tag first to see if the tests pass. If they pass, you can tag and git push origin master --tags and trigger this workflow.

Copy link

I agree that it's not a regression to do it this way and that it's fine to move forward. I would eventually like to test the exact artifacts we're uploading to PyPI, particularly once we start building platform wheels.

@bocklund bocklund merged commit 391b222 into develop May 22, 2021
@bocklund bocklund deleted the setuptools-builds branch May 22, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants