Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Refactor cythonization #334

merged 10 commits into from May 23, 2021


Copy link

  • Move extension definitions out to the top level to make easier to read
  • Add a dictionary of global compiler directives that currently just sets the language level to 3 (fixing a FutureWarning)
  • Fixes a few cythonization warnings about typing indices

As of this PR, there's currently no warnings being emitted from the Cythonizing step. There's still some warnings in the compiling step but some (all?), like the deprecated NumPy API warnings, are out of our control.

Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #334 (f9670dd) into develop (fdd14be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #334   +/-   ##
  Coverage    84.55%   84.55%           
  Files           45       45           
  Lines         4526     4526           
  Hits          3827     3827           
  Misses         699      699           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd14be...f9670dd. Read the comment docs.

Copy link

Can the extra compiler and link arguments be removed? I think they are mostly (entirely?) irrelevant now.

Copy link
Collaborator Author

Can the extra compiler and link arguments be removed? I think they are mostly (entirely?) irrelevant now.

Looks like it! Removed.

@bocklund bocklund requested a review from richardotis May 23, 2021 00:34
@bocklund bocklund merged commit 29fa9b8 into pycalphad:develop May 23, 2021
@bocklund bocklund deleted the MAINT-refactor-cython-directives branch May 23, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants