New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Refactor setup.py cythonization #334
MAINT: Refactor setup.py cythonization #334
Conversation
Also enable passing CYTHON_COMPILER_DIRECTIVES
Codecov Report
@@ Coverage Diff @@
## develop #334 +/- ##
========================================
Coverage 84.55% 84.55%
========================================
Files 45 45
Lines 4526 4526
========================================
Hits 3827 3827
Misses 699 699 Continue to review full report at Codecov.
|
Can the extra compiler and link arguments be removed? I think they are mostly (entirely?) irrelevant now. |
Looks like it! Removed. |
As of this PR, there's currently no warnings being emitted from the Cythonizing step. There's still some warnings in the compiling step but some (all?), like the deprecated NumPy API warnings, are out of our control.