Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: test_dilute_condition: Loosen tolerance back to 0.8.x value #336

Merged
merged 1 commit into from May 22, 2021

Conversation

richardotis
Copy link
Collaborator

This fixes numerical differences that arise on some Windows setups (pip versus conda).

@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #336 (547536d) into develop (fdd14be) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #336   +/-   ##
========================================
  Coverage    84.55%   84.55%           
========================================
  Files           45       45           
  Lines         4526     4526           
========================================
  Hits          3827     3827           
  Misses         699      699           
Impacted Files Coverage Δ
pycalphad/tests/test_equilibrium.py 97.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd14be...547536d. Read the comment docs.

@richardotis richardotis added this to the 0.9 milestone May 22, 2021
@richardotis richardotis requested a review from bocklund May 22, 2021 23:50
@richardotis richardotis merged commit 3ad4661 into develop May 22, 2021
@richardotis richardotis deleted the fix-inconsistent-result branch May 22, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants