Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: potential sorting bug in lower_convex_hull #339



Copy link

Fixes a sorting bug introduced into lower_convex_hull by #329. We used to rely on indep_conds for sorting the state variables, but now we use the state_variables variable directly and indep_conds is dead code.

This PR sorts the state_variables now.

@bocklund bocklund requested a review from richardotis May 24, 2021 16:23
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #339 (f81a257) into develop (4e399bb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #339   +/-   ##
  Coverage    84.25%   84.25%           
  Files           45       45           
  Lines         4529     4529           
  Hits          3816     3816           
  Misses         713      713           
Impacted Files Coverage Δ
pycalphad/core/ 97.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e399bb...f81a257. Read the comment docs.

@bocklund bocklund merged commit 6219d4d into pycalphad:develop May 24, 2021
@bocklund bocklund deleted the FIX-lower_convex_hull-sorting-bug branch May 24, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants