Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Model: Change some uses of subs to symbol_replace for performance #340

merged 1 commit into from May 25, 2021


Copy link

This makes a significant performance difference for multicomponent models with magnetism.

@richardotis richardotis added this to the 0.9 milestone May 25, 2021
@richardotis richardotis requested a review from bocklund May 25, 2021 22:38
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #340 (d862ecf) into develop (6219d4d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #340   +/-   ##
  Coverage    84.25%   84.25%           
  Files           45       45           
  Lines         4529     4529           
  Hits          3816     3816           
  Misses         713      713           
Impacted Files Coverage Δ
pycalphad/ 91.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6219d4d...d862ecf. Read the comment docs.

@richardotis richardotis merged commit 9593ab5 into develop May 25, 2021
26 checks passed
@richardotis richardotis deleted the improve-model-perf branch May 25, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants