Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX/TST: Adjust MIN_SITE_FRACTION and add tests #344

Merged
merged 2 commits into from Jun 1, 2021

Conversation

richardotis
Copy link
Collaborator

@richardotis richardotis commented May 31, 2021

  • Change MIN_SITE_FRACTION to 1e-14
  • Add a test to confirm the high-temperature jitter in Al-Ni is fixed by the change (was checked before and after)
  • Adjust test_degree_of_ordering tolerance to account for sensitivity of our degree-of-ordering metric to differences in MIN_SITE_FRACTION
  • Add a test to close Chemical potential conditions not converging for Al-Fe B2_BCC #259
  • Add Windows compiled extension type .pyd to .gitignore

@richardotis richardotis added this to the 0.9 milestone May 31, 2021
@richardotis richardotis requested a review from bocklund May 31, 2021 22:28
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #344 (7aa0207) into develop (90696b6) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #344      +/-   ##
===========================================
+ Coverage    89.70%   89.75%   +0.04%     
===========================================
  Files           44       44              
  Lines         4255     4275      +20     
===========================================
+ Hits          3817     3837      +20     
  Misses         438      438              
Impacted Files Coverage Δ
pycalphad/core/constants.py 100.00% <100.00%> (ø)
pycalphad/tests/test_equilibrium.py 97.33% <100.00%> (+0.19%) ⬆️
pycalphad/tests/test_model.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90696b6...7aa0207. Read the comment docs.

@richardotis richardotis merged commit 373d121 into pycalphad:develop Jun 1, 2021
@richardotis richardotis deleted the fix-259 branch June 1, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chemical potential conditions not converging for Al-Fe B2_BCC
2 participants