Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: pyparsing 3.0 support #348

merged 2 commits into from Jun 5, 2021


Copy link

Fixes gh-347, which reports a regression with the pyparsing 3.0 pre-release. This change should be backwards compatible with pyparsing 2.4+. I do not know the precise root cause of the regression, as I was able to narrow the problem down empirically. My best guess is that the semantics of pyparsing.White() have changed in some way.

@bocklund This should be run against your private collection of TDBs to identify regressions.


  • If any dependencies have changed, the changes are reflected in the
    • environment-dev.yml

@richardotis richardotis added the bug label Jun 4, 2021
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #348 (48b340b) into develop (2e79f0f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #348   +/-   ##
  Coverage    89.75%   89.75%           
  Files           44       44           
  Lines         4275     4275           
  Hits          3837     3837           
  Misses         438      438           
Impacted Files Coverage Δ
pycalphad/io/ 87.62% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e79f0f...48b340b. Read the comment docs. Show resolved Hide resolved
pycalphad/io/ Show resolved Hide resolved
Copy link

bocklund commented Jun 4, 2021

I’ll try to get the pre-release installed tomorrow and test against the databases I have.

Copy link

bocklund commented Jun 5, 2021

I compared 3.0.0b2 to 2.4.7 locally and there were no regressions across 522 databases.

@bocklund bocklund self-requested a review June 5, 2021 01:37
@richardotis richardotis merged commit 4c265a0 into pycalphad:develop Jun 5, 2021
@richardotis richardotis deleted the fix-347 branch June 5, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Potential pyparsing 3.0 breakages
2 participants