Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add support for all TC parameters as of 2021b documentation #358

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

bocklund
Copy link
Collaborator

This PR adds support for parameters supported by Thermo-Calc as of the 2021b documentation set.

Notably, VA, VC and VK molar volume parameters were added and some property model parameters were added (new in the Thermo-Calc 2021b documentation).

None of the new parameters affect the Gibbs energy, so we should still remain at feature parity with the energy contributions of Thermo-Calc. The new property model parameters don't have model implementations yet, but this may open the door for an interested user.

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #358 (5df7b0e) into develop (f5bd032) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #358   +/-   ##
========================================
  Coverage    89.75%   89.75%           
========================================
  Files           44       44           
  Lines         4275     4275           
========================================
  Hits          3837     3837           
  Misses         438      438           
Impacted Files Coverage Δ
pycalphad/io/tdb_keywords.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bd032...5df7b0e. Read the comment docs.

@bocklund bocklund merged commit 669815c into pycalphad:develop Jun 29, 2021
@bocklund bocklund deleted the update-TDB-parameters branch June 29, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants