Skip to content

FIX: Database parsing fails if some tokens are not uppercase #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

nandiniraja348
Copy link
Contributor

Updated the database string to always be parsed to uppercase. Also passed the test cases mentioned in the issue #359

@richardotis richardotis linked an issue Aug 1, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #364 (4fed1c1) into develop (e9c5d6d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #364   +/-   ##
========================================
  Coverage    89.86%   89.87%           
========================================
  Files           44       44           
  Lines         4341     4345    +4     
========================================
+ Hits          3901     3905    +4     
  Misses         440      440           
Impacted Files Coverage Δ
pycalphad/io/tdb.py 87.62% <100.00%> (ø)
pycalphad/tests/test_database.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9c5d6d...4fed1c1. Read the comment docs.

@richardotis richardotis self-requested a review August 1, 2021 18:01
@richardotis
Copy link
Collaborator

@bocklund Any thoughts on merging this?

@bocklund
Copy link
Collaborator

bocklund commented Aug 1, 2021

LGTM

@richardotis richardotis merged commit f060c23 into pycalphad:develop Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database parsing fails if some tokens are not uppercase
3 participants