FIX: Improved custom state variable support #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #365 +/- ##
========================================
Coverage 89.87% 89.87%
========================================
Files 44 44
Lines 4345 4345
========================================
Hits 3905 3905
Misses 440 440
Continue to review full report at Codecov.
|
bocklund
reviewed
Aug 6, 2021
…o zero" This reverts commit 5a95482.
bocklund
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two small improvements to better support the use of custom state variable objects.
One change silences a callables warning that would occur every time a custom state variable was used; this has been improved to only warn when expected state variables are missing. The other change relaxes an implicit assumption / bug that state variables would never be equal to zero (when calculating a percent change in value); now we detect this case and switch to an absolute difference.