Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: calculate: Phase index offset for associate models #368

Merged
merged 5 commits into from
Aug 11, 2021

Conversation

richardotis
Copy link
Collaborator

Fixes gh-367.

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #368 (130b2f1) into develop (4461299) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #368      +/-   ##
===========================================
+ Coverage    89.91%   89.93%   +0.01%     
===========================================
  Files           44       44              
  Lines         4362     4370       +8     
===========================================
+ Hits          3922     3930       +8     
  Misses         440      440              
Impacted Files Coverage Δ
pycalphad/core/calculate.py 92.67% <100.00%> (+0.03%) ⬆️
pycalphad/tests/test_equilibrium.py 97.70% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4461299...130b2f1. Read the comment docs.

Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
@richardotis richardotis merged commit 7cc854d into pycalphad:develop Aug 11, 2021
@richardotis richardotis deleted the fix-367 branch August 11, 2021 17:34
bocklund pushed a commit to PhasesResearchLab/ESPEI that referenced this pull request Aug 13, 2021
…rom non-pure element species (#208)

Propagate changes from [PR 368](pycalphad/pycalphad#368) to espei.shadow_functions.calculate_ to fix the phase index offset for Database with non-pure element species.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index error when using binplot
2 participants