-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new axes with specified projection without using gca(...) #370
Create new axes with specified projection without using gca(...) #370
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #370 +/- ##
===========================================
- Coverage 89.93% 89.92% -0.01%
===========================================
Files 44 44
Lines 4370 4368 -2
===========================================
- Hits 3930 3928 -2
Misses 440 440
Continue to review full report at Codecov.
|
Thanks Trevor! My only question was to figure out if matplotlib 3.3 (our current required minimum version) was recent enough for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the TernaryExamples notebook in the examples folder with the same fix?
Happy to help @richardotis! Enjoying the new (to me) functionality. |
@tkphd General isopleth calculation is on the roadmap and probably the biggest feature blocking "pycalphad 1.0". @bocklund has been thinking hard about general phase diagram mapping, including isopleth calculation. A recent paper from Sundman et al describes the challenges with the general case: https://doi.org/10.1016/j.calphad.2021.102330 In short, there's a lot of state to track for multicomponent isopleths, and it's easy to accidentally compute a metastable diagram. I can't promise a timeline except to say that this year's new energy minimization module (shipped in 0.9) was definitely a prerequisite to further progress, and I think we're in good position to ship "something" related to mapping in 2022. We are open to collaborations in this direction, |
Closes #369.