Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new axes with specified projection without using gca(...) #370

Conversation

tkphd
Copy link
Contributor

@tkphd tkphd commented Aug 27, 2021

Closes #369.

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #370 (6d6fc9e) into develop (77f25eb) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #370      +/-   ##
===========================================
- Coverage    89.93%   89.92%   -0.01%     
===========================================
  Files           44       44              
  Lines         4370     4368       -2     
===========================================
- Hits          3930     3928       -2     
  Misses         440      440              
Impacted Files Coverage Δ
pycalphad/plot/eqplot.py 68.88% <100.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f25eb...6d6fc9e. Read the comment docs.

@richardotis
Copy link
Collaborator

Thanks Trevor! My only question was to figure out if matplotlib 3.3 (our current required minimum version) was recent enough for subplot_kw, but it looks like the feature is at least a few years old.

@richardotis richardotis self-requested a review August 27, 2021 19:14
Copy link
Collaborator

@richardotis richardotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the TernaryExamples notebook in the examples folder with the same fix?

@tkphd
Copy link
Contributor Author

tkphd commented Aug 27, 2021

Happy to help @richardotis! Enjoying the new (to me) functionality.
Quaternary dataviz next?

@richardotis richardotis merged commit e36e369 into pycalphad:develop Aug 27, 2021
@tkphd tkphd deleted the issue369-deprecation_warning_in_ternary_example branch August 27, 2021 21:14
@richardotis
Copy link
Collaborator

@tkphd General isopleth calculation is on the roadmap and probably the biggest feature blocking "pycalphad 1.0". @bocklund has been thinking hard about general phase diagram mapping, including isopleth calculation. A recent paper from Sundman et al describes the challenges with the general case: https://doi.org/10.1016/j.calphad.2021.102330

In short, there's a lot of state to track for multicomponent isopleths, and it's easy to accidentally compute a metastable diagram. I can't promise a timeline except to say that this year's new energy minimization module (shipped in 0.9) was definitely a prerequisite to further progress, and I think we're in good position to ship "something" related to mapping in 2022. We are open to collaborations in this direction,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecation warning in ternary example
2 participants