-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Fix TDB line length bugs #392
Merged
bocklund
merged 8 commits into
pycalphad:develop
from
bocklund:FIX-database-line-length
Jan 29, 2022
Merged
FIX: Fix TDB line length bugs #392
bocklund
merged 8 commits into
pycalphad:develop
from
bocklund:FIX-database-line-length
Jan 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardotis
requested changes
Jan 29, 2022
Codecov Report
@@ Coverage Diff @@
## develop #392 +/- ##
===========================================
+ Coverage 89.95% 89.98% +0.03%
===========================================
Files 44 44
Lines 4369 4383 +14
===========================================
+ Hits 3930 3944 +14
Misses 439 439
Continue to review full report at Codecov.
|
richardotis
reviewed
Jan 29, 2022
richardotis
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs related to writing TDB files and reflowing lines:
reflow_text
where lines that are too long and contain no valid linebreak characters would result in an infinite loop of finding the samelinebreak_idx
and emitting the same line until running out of memory. Now lines that cannot be reflowed to under thelinewidth
raises an error.CONSTITUENTS
line (it's now,
instead of,
) soreflow_text
can reflow the line at any element. This fixes a bug where phases with many constituents would trigger the infinite loop (and now error) from (1).A test is added for each case.