Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: hyperplane: Incorrectly throwing out stable starting points #428

Merged
merged 3 commits into from
Aug 19, 2022

Conversation

richardotis
Copy link
Collaborator

Fixes #427

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #428 (12209f7) into develop (04b870e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #428   +/-   ##
========================================
  Coverage    90.24%   90.25%           
========================================
  Files           50       50           
  Lines         7723     7726    +3     
========================================
+ Hits          6970     6973    +3     
  Misses         753      753           
Impacted Files Coverage Δ
pycalphad/core/hyperplane.pyx 93.33% <100.00%> (-0.35%) ⬇️
pycalphad/tests/test_equilibrium.py 98.44% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@richardotis richardotis requested a review from bocklund August 15, 2022 00:48
@bocklund
Copy link
Collaborator

I re-ran the ternary example, it seems fixed and significantly faster. In fact, I was getting an error on develop, some Gibbs phase rule violation in array sizes, I believe.

master branch (4m44s runtime):
cu-al-y-master-4m44s

12209f7 (0m31s runtime):
cu-al-y-fix-427-0m31s

I honestly don't know how this slipped by for so long.

@richardotis richardotis merged commit 73879c8 into pycalphad:develop Aug 19, 2022
@richardotis richardotis deleted the fix-427 branch August 19, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Solver: convergence failure in Cr-Ti-V
2 participants