BLD: deploy.yaml: PyPI trusted publisher support#523
Merged
richardotis merged 7 commits intopycalphad:developfrom Mar 31, 2024
Merged
BLD: deploy.yaml: PyPI trusted publisher support#523richardotis merged 7 commits intopycalphad:developfrom
richardotis merged 7 commits intopycalphad:developfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #523 +/- ##
========================================
Coverage 90.48% 90.48%
========================================
Files 50 50
Lines 7880 7880
========================================
Hits 7130 7130
Misses 750 750 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
The TestPyPI piece can only be tested on a repo branch, so I will merge to see if this works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for trusted publishing on PyPI using GitHub Actions as an OpenID Connect provider. I have already performed the setup on the PyPI side to allow for this.
After this is merged, we can revoke the dedicated PyPI upload token for pycalphad and use GitHub Actions as our sole deployment tool. We already do this, but this will prevent a leaked token from being able to manipulate release artifacts out-of-band.