Skip to content

BLD/CI: Remove local version specifier for TestPyPI uploads#534

Merged
richardotis merged 11 commits intopycalphad:developfrom
richardotis:remove-local-version-id
Jul 4, 2024
Merged

BLD/CI: Remove local version specifier for TestPyPI uploads#534
richardotis merged 11 commits intopycalphad:developfrom
richardotis:remove-local-version-id

Conversation

@richardotis
Copy link
Collaborator

@richardotis richardotis commented Jul 4, 2024

Removes local version specifier (+hash) from CI builds to allow for upload of artifacts to TestPyPI. Follows the strategy outlined in pypa/setuptools-scm#455 (comment)

Checklist

  • If any dependencies have changed, the changes are reflected in the
    • setup.py (runtime requirements)
    • pyproject.toml (build requirements)
    • requirements-dev.txt (build and development requirements)

@codecov
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.46%. Comparing base (6c7b009) to head (920380a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #534   +/-   ##
========================================
  Coverage    90.46%   90.46%           
========================================
  Files           50       50           
  Lines         7885     7885           
========================================
  Hits          7133     7133           
  Misses         752      752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardotis
Copy link
Collaborator Author

The environment variable isn't being detected properly. I think a different approach is needed.

@richardotis
Copy link
Collaborator Author

This appears to be working as of e11ac48. Now I'm going to enable the branch condition, wait for tests to pass, merge to develop, and confirm the upload to TestPyPI works.

@richardotis richardotis changed the title BLD: Remove local version specifier for TestPyPI uploads BLD/CI: Remove local version specifier for TestPyPI uploads Jul 4, 2024
@richardotis richardotis merged commit d99c485 into pycalphad:develop Jul 4, 2024
@richardotis richardotis deleted the remove-local-version-id branch July 4, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant