BLD/CI: Remove local version specifier for TestPyPI uploads#534
Merged
richardotis merged 11 commits intopycalphad:developfrom Jul 4, 2024
Merged
BLD/CI: Remove local version specifier for TestPyPI uploads#534richardotis merged 11 commits intopycalphad:developfrom
richardotis merged 11 commits intopycalphad:developfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #534 +/- ##
========================================
Coverage 90.46% 90.46%
========================================
Files 50 50
Lines 7885 7885
========================================
Hits 7133 7133
Misses 752 752 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
The environment variable isn't being detected properly. I think a different approach is needed. |
This reverts commit 37c82b6.
Collaborator
Author
|
This appears to be working as of e11ac48. Now I'm going to enable the branch condition, wait for tests to pass, merge to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes local version specifier (
+hash) from CI builds to allow for upload of artifacts to TestPyPI. Follows the strategy outlined in pypa/setuptools-scm#455 (comment)Checklist
setup.py(runtime requirements)pyproject.toml(build requirements)requirements-dev.txt(build and development requirements)