Skip to content

Conversation

@richardotis
Copy link
Collaborator

@richardotis richardotis commented Jul 7, 2024

One more Numpy 2.0 compatibility issue (missed because the plotting code wasn't run in the test suite). This PR adds a 'functional' test (i.e. does it run without errors) for binplot to ensure we don't miss potential deprecations or other regressions in the plotting module.

@richardotis richardotis added the bug label Jul 7, 2024
@richardotis richardotis requested a review from bocklund July 7, 2024 20:45
@codecov
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.86%. Comparing base (da2bbbb) to head (a87171c).
Report is 1 commits behind head on develop.

Files Patch % Lines
pycalphad/plot/binary/compsets.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #538      +/-   ##
===========================================
+ Coverage    90.31%   90.86%   +0.55%     
===========================================
  Files           50       50              
  Lines         7885     7892       +7     
===========================================
+ Hits          7121     7171      +50     
+ Misses         764      721      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardotis richardotis added this to the 0.10.5 milestone Jul 8, 2024
@richardotis richardotis merged commit a3ebaa0 into pycalphad:develop Jul 11, 2024
@richardotis richardotis deleted the fix-numpy-inf branch July 11, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants