Skip to content

Conversation

@bocklund
Copy link
Collaborator

@bocklund bocklund commented Jul 12, 2024

Changes the error message for mismatched disordered and ordered sublattices from this:

ValueError: Number of interstitial sublattices for the disordered phase (1) and the ordered phase (5) do not match. Got substitutional sublattice indices of [].

to this:

ValueError: Number of interstitial sublattices for the disordered phase FCC_A1 (1) and the ordered phase GP_MAT (5) do not match. Found substitutional sublattices in the ordered phase with indices of []. Ensure that all the constituents in the substitutional sublattices for the disordered and ordered phase match exactly and the constituents in the interstitial sublattices for the disordered and ordered phase match exactly.

@bocklund bocklund changed the title ENH: Improve error message for ordering models having mismatched cons… ENH: Improve error message for ordering models having mismatched constituents Jul 12, 2024
@bocklund bocklund requested a review from richardotis July 12, 2024 00:12
@codecov
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (a3ebaa0) to head (4bd0083).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #541   +/-   ##
========================================
  Coverage    90.86%   90.86%           
========================================
  Files           50       50           
  Lines         7892     7893    +1     
========================================
+ Hits          7171     7172    +1     
  Misses         721      721           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bocklund bocklund added this to the 0.10.5 milestone Jul 12, 2024
@bocklund bocklund merged commit 47be80e into pycalphad:develop Jul 12, 2024
@bocklund bocklund deleted the improve-ordering-error-message branch July 12, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants