ENH: Mapping: Small performance fix#552
Merged
richardotis merged 1 commit intopycalphad:developfrom Jul 27, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #552 +/- ##
========================================
Coverage 91.74% 91.75%
========================================
Files 77 77
Lines 11981 11982 +1
========================================
+ Hits 10992 10994 +2
+ Misses 989 988 -1 ☔ View full report in Codecov by Sentry. |
bocklund
approved these changes
Jul 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
FastFunctionFactory.getfunc()out of a tight loop inside ofPhaseRecord.prop_2d(). Despite hitting the cache, it seems thatgetfunc()takes appreciable time and, for large numbers of inputs (num_imps), it can become as much as 40% of the runtime of that function. For large values ofpdens(such as the value 500, used by default inside of mapping), this significantly impacts thecalculatefunction.On my laptop, this change shaves a few seconds off the mapping tests.