Repository navigation
FIX: ParseException handling in pyparsing 3.2.0 - #584
Merged
richardotis merged 3 commits intoDec 16, 2024
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #584 +/- ##
========================================
Coverage 91.99% 91.99%
========================================
Files 77 77
Lines 12271 12273 +2
========================================
+ Hits 11289 11291 +2
Misses 982 982 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bocklund
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent change in pyparsing added caching to attributes on ParseException objects using the
cached_propertydecorator. Those caches are not invalidated when thepstrandlocfor the ParseException objects are modified (as we do, to provide more accurate line numbers, since #550 ).The caches for these properties are stored as attributes on the instances with the same name as the property, so it is easy to clear the cache using
obj.__dict__.pop('property_name', None). This is backwards-compatible since it's a no-op on previous versions of pyparsing, where only thepropertydecorator is present. Details of how this works can be found in the answers to this StackOverflow question.