New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: sympydiff_utils: Replace some constants to ensure compilation #91

Merged
merged 1 commit into from May 12, 2017

Conversation

Projects
None yet
2 participants
@richardotis
Collaborator

richardotis commented May 10, 2017

This fixes an issue with some unpublished custom Models reported by a user to have issues when using calculate to compute a property besides GM (e.g., CPM), where that property's symbolic derivative can generate zoo (complex infinity) or the constant PI.

@bocklund This is a quick fix designed to be pushed into a new minor release. (A better fix would fix the code generation side rather than search-and-replace the SymPy object.) There is a workshop next week where the user's work will prominently feature pycalphad, and we want to make sure the calculations run.

@richardotis richardotis requested a review from bocklund May 10, 2017

@bocklund

This is fine. Will you open an issue for the long term fix?

@richardotis richardotis merged commit 667ec53 into develop May 12, 2017

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 85.184%
Details

@richardotis richardotis deleted the fix_sympydiff_prop_constants branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment