Add socket_factory and SSL socket support #175

Merged
merged 1 commit into from Nov 8, 2012

Conversation

Projects
None yet
3 participants
Contributor

iamaleksey commented Nov 5, 2012

Add socket_factory and SSL socket support (for C* 1.2, trunk)

@thobbs thobbs merged commit c3e4c07 into pycassa:master Nov 8, 2012

Owner

hannosch commented Nov 8, 2012

Merging this request broke the tests under Python 2.5 (https://travis-ci.org/pycassa/pycassa/jobs/3105548). TSSLSocket does an "import ssl", but this module was only added to Python 2.6.

Either we need to stop supporting Python 2.5 or do some conditional imports and mark this feature as Python 2.6+ only.

Owner

thobbs commented Nov 8, 2012

Given that Thrift 0.9.0 doesn't support 2.5 and that it's quite easy today to run 2.6+, I'm inclined to say we should drop support for 2.5 and see how many people actually care.

Owner

hannosch commented Nov 9, 2012

Sounds good to me, I updated some docs and code at #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment