Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

cf.get returning empty dict on empty column slice #187

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

reikje commented Feb 13, 2013

This is similar to what multiget already does. Case 2 here: #50 - which has never been implemented?

Owner

thobbs commented Feb 15, 2013

Unfortunately, this is quite backwards-incompatible from an API standpoint and it doesn't greatly improve the experience of working with get(): users may now have to catch NotFoundExceptions and check for empty dicts.

I closed #50 because I was mistaken when I created it. Raising a NotFoundException doesn't actually make anything ambiguous that wasn't already ambiguous before.

For what it's worth, if I had designed the original API, I probably would have gone with empty dicts instead of raising an exception, but for the sake of backwards compatibility, that can't lightly be changed at this point.

@thobbs thobbs closed this Feb 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment