From 8b537a154cfc7285775093cf8b8ecc929b82f555 Mon Sep 17 00:00:00 2001 From: EmilyBourne Date: Tue, 9 Apr 2024 11:31:59 +0200 Subject: [PATCH] Improve Windows install (#1817) In the Windows installation, do not use the `sleep` command to wait for an executable to finish, as this leads to random crashes. Instead, use the proper Windows commands (taken from PR #1180) to wait for the execution. --- .github/actions/windows_install/action.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/actions/windows_install/action.yml b/.github/actions/windows_install/action.yml index d5a902a9c7..7d0b630de7 100644 --- a/.github/actions/windows_install/action.yml +++ b/.github/actions/windows_install/action.yml @@ -52,10 +52,8 @@ runs: curl https://github.com/microsoft/Microsoft-MPI/releases/download/v10.1.1/msmpisdk.msi -o msmpisdk.msi # # Install MS MPI - ./msmpisetup.exe -unattend -verbose - sleep 30 - msiexec /quiet /i msmpisdk.msi - sleep 1 + Start-Process msmpisetup.exe -Wait -ArgumentList '-unattend -verbose' + Start-Process msiexec -Wait -ArgumentList '/quiet /i msmpisdk.msi' echo "MS MPI runtime and SDK installed" shell: powershell - name: Setup MPI