Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uses of typing compatible with python 3.5.1 / 3.5.0 - [merged] #1199

Closed
asottile opened this issue Apr 3, 2021 · 4 comments
Closed

Comments

@asottile
Copy link
Member

asottile commented Apr 3, 2021

In GitLab by @asottile on Jan 30, 2019, 14:06

Merges typing_3_5_1 -> master

Resolves #498

@asottile asottile added this to the 3.7.3 milestone Apr 3, 2021
@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @codecov on Jan 30, 2019, 14:07

Codecov Report

Merging #294 into master will increase coverage by 0.03%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
+ Coverage    78.9%   78.94%   +0.03%     
==========================================
  Files          25       25              
  Lines        2366     2365       -1     
  Branches      393      393              
==========================================
  Hits         1867     1867              
- Misses        414      415       +1     
+ Partials       85       83       -2
Impacted Files Coverage Δ
src/flake8/utils.py 83.06% <100%> (+0.43%) ⬆️
src/flake8/main/application.py 74.21% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d1a426...eb886a2. Read the comment docs.

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Jan 30, 2019, 14:20

root@b08f09e2dac8:/# flake8 --version
3.7.2 (mccabe: 0.6.1, pycodestyle: 2.5.0, pyflakes: 2.1.0) CPython 3.5.1 on Linux

validated this with docker

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Jan 30, 2019, 14:20

mentioned in commit e21d74f

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Jan 30, 2019, 14:20

merged

@asottile asottile closed this as completed Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant