-
-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip files no longer ignores from stdin #1771
Comments
Hi @jeffwillette, I'm sorry for the confusion! However, as written, I cannot see how it could work on any version of isort or any command in general.
|
that could potentially work with a pull request to the vim plugin. I tried running it on the shell and I got an exception that was raised. Is this exception expected? It seems like it should be handled gracefully instead of raising an exception...
|
@jeffwillette good call out! I've improved this behavior so the skip will be silent in 5.9.2 |
I had previsouly filed an issue asking for help with ignoring
__init__.py
files #1632. Along the way, something changed and this command no longer ignores__init__.py
files. The way the command is being run is as follows...It might seem a little bit strange to skip a file and then read it from stdin, but this happens because NeoVim + ALE (https://github.com/dense-analysis/ale) runs isort on every save and reads from the current vim buffer which usually has a filepath of something like
/tmp/<random chars>/__init__.py.
To the best of my knowledge, NeoVim and ALE have always read from stdin, so it is very unlikely that the behavior on that end has changed.Has there been any change within some of the recent isort versions which might have changed this behavior?
The text was updated successfully, but these errors were encountered: